No Clone Method fixes. #6571
Merged
No Clone Method fixes. #6571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pulled out 2 inner classes
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6571 +/- ##
============================================
+ Coverage 11.43% 11.58% +0.14%
+ Complexity 6455 6402 -53
============================================
Files 1087 1085 -2
Lines 139329 139604 +275
Branches 21542 21531 -11
============================================
+ Hits 15935 16170 +235
- Misses 121802 121861 +59
+ Partials 1592 1573 -19 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the "No Clone Methods" listed under the CodeQL security tabs on MegaMek and is related to the 2 inner classes to be outer classes due to being used outside of the parent classes.
General IDEA Clean up as well.
Requires MegaMek#6836 before merging.